Add a check in JavaHttpClientTransport to verify if we can add the host header#764
Merged
Merged
Conversation
adwsingh
force-pushed
the
adwsingh/host-header-allow-verification
branch
from
June 10, 2025 23:19
06b6cfe to
f407ced
Compare
rhernandez35
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
There is a race in JavaHttpClientTransport where if the
jdk.internal.net.http.common.Utilsclass is loaded and initialized before JavaHttpClientTransport then we don't have an opportunity to influence the restricted headers via any system property. This PR adds a guard to detect it and fail fast.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.